On 03.06.2010 15:16, ma...@apache.org wrote:
Author: markt
Date: Thu Jun 3 13:16:27 2010
New Revision: 950983
URL: http://svn.apache.org/viewvc?rev=950983&view=rev
Log:
Enable access logs by default for 7.0.x
Modified:
tomcat/trunk/conf/server.xml
Modified: tomcat/trunk/conf/server.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/conf/server.xml?rev=950983&r1=950982&r2=950983&view=diff
==============================================================================
--- tomcat/trunk/conf/server.xml (original)
+++ tomcat/trunk/conf/server.xml Thu Jun 3 13:16:27 2010
@@ -127,10 +127,8 @@
<!-- Access log processes all example.
Documentation at: /docs/config/valve.html -->
-<!--
<Valve className="org.apache.catalina.valves.AccessLogValve"
directory="logs"
prefix="localhost_access_log." suffix=".txt" pattern="common"
resolveHosts="false"/>
- -->
</Host>
</Engine>
+1000
Another related observation: Users often are not aware that they can
substitute "common" with an individual log pattern, although that is
very often essential (like including %D etc.). Even though many know
similar constructs from Apache httpd, it's not obvious for them that
they can substitute the word "common" with a pattern.
Should we add an example pattern to server.xml? Or would it be easier
understandable if we removed the abbreviation "common" from the default
config and replace it with the full pattern?
There's also the topic that the common pattern contains quotation marks,
which you can't add verbatim to the attribute if you want to extend the
common pattern with additional items. So adding an example or using the
real pattern in the default configuration would show users how to work
around that (" or similar).
My .1 Euro Cents.
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
