On 15.05.2010 22:17, Mark Thomas wrote:
On 15/05/2010 00:14, rj...@apache.org wrote:
Author: rjung
Date: Fri May 14 23:14:51 2010
New Revision: 944511
URL: http://svn.apache.org/viewvc?rev=944511&view=rev
Log:
Check whether context is null.
-1 on this change. I'll be reverting it shortly.
1. It isn't necessary. There is a null check in
ApplicationSessionCookieConfig.getSessionCookieName()
2. It bypasses the session cookie config
Thanks Mark. I started to worry about the same code in TC6 and thought
it would be easiest to propose a patch by comitting to trunk first - and
then overlooked a subtle code difference.
In TC 6 your proposed session cookie configuration patch uses
"context.getSessionCookieName()", so the above patch might still make
sense there. It's rubbish for trunk though.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
