Author: rjung
Date: Fri May 14 23:22:40 2010
New Revision: 944514
URL: http://svn.apache.org/viewvc?rev=944514&view=rev
Log:
Add patches.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=944514&r1=944513&r2=944514&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri May 14 23:22:40 2010
@@ -140,11 +140,27 @@ PATCHES PROPOSED TO BACKPORT:
in if (log.isDebugEnabled()) { ... } block
s/Globals.SESSION_COOKIE_NAME/newCookie.getName()/
)
+
rjung: In CoyoteAdapter.parseSessionCookiesId(): should there be a check
for context != null before calling context.getSessionCookieName()?
- At least a few lines above that place we chaeck context != null before
calling
+ At least a few lines above that place we check context != null before
calling
context.getCookies(), so it seems someone wasn't sure, whether context could
- be null or not.
+ be null or not. I propose adding
+ http://svn.apache.org/viewvc?rev=944511&view=rev
+ +1: rjung
+ -1:
+
+ rjung: In Request.configureSessionCookie(): should there be a check
+ for context != null before calling context.getSessionCookieDomain()?
+ At least a few lines above that place we check context != null before
calling
+ context.getSessionCookiePath(), so it seems someone wasn't sure, whether
context could
+ be null or not. I propose adding
+ http://people.apache.org/~rjung/patches/2010-05-14-context-null-check.patch
+ It can't be directly applied to trunk which uses
+ ApplicationSessionCookieConfig.createSessionCookie(). Do we need to add the
null checks
+ into that method?
+ +1: rjung
+ -1:
* sessionCounter and expiredSessions declares as long instead of int.
http://svn.apache.org/viewvc?view=revision&revision=934337
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
