Author: kkolinko Date: Tue Feb 16 04:36:31 2010 New Revision: 910394 URL: http://svn.apache.org/viewvc?rev=910394&view=rev Log: proposals
Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=910394&r1=910393&r2=910394&view=diff ============================================================================== --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Feb 16 04:36:31 2010 @@ -47,7 +47,13 @@ passes. http://people.apache.org/~markt/patches/2010-02-02-bug42390-tc5.patch +1: markt - -1: + -1: kkolinko: The same concerns as for TC 6 patch + + Alternative proposal: + https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c22 + (https://issues.apache.org/bugzilla/attachment.cgi?id=24993) + +1: kkolinko + -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44041 Threading issue in class loading (using Filip's suggestion) Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=910394&r1=910393&r2=910394&view=diff ============================================================================== --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 16 04:36:31 2010 @@ -195,19 +195,6 @@ 2) It should navigate up the parents chain. The SimpleTag can be one of our parents, not necessary the immediate one. - 2. I think that BZ 48616 cannot/should not be fixed - see Comment 15 to - the issue. - - 3. Should we fix BZ 42390 in TC 5.5, and bring on BZ 48616 there, if it - was historically working? I have doubts. - - Reviewing this as a whole, I have questions regarding the following field: - ScriptingVariabler#ScriptingVariableVisitor#scriptVars - It is used to introduce behaviour like requested in BZ 48616, but ... - The BZ 42390 fix (r804734) effectively eliminates it. It looks like - it'd be better to remove it and care about redeclarations somewhere - else. - - to discuss on dev@ Additional patches (trivial): http://svn.apache.org/viewvc?rev=905643&view=rev (misprint) @@ -215,6 +202,13 @@ +1: kkolinko, markt -1: + Alternative proposal: + https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c21 + (https://issues.apache.org/bugzilla/attachment.cgi?id=24992) + +1: kkolinko + -1: + + * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48612 Prevent exception on shutdown Port of r896193 and r905343 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org