https://issues.apache.org/bugzilla/show_bug.cgi?id=48258
--- Comment #6 from donn.ai...@gmail.com 2009-12-01 18:37:27 UTC --- (In reply to comment #5) > The general approach is good. > > Some misc comments in no particular order: > - Use 4 spaces rather than tabs > - Remove the changes that just add/remove whitespace at the end of a line > - Some methods are missing JavaDocs > - Provide the spelling corrections as a separate patch (makes things easier to > review) > - The new attribute needs documenting. > - Some thought needs to be given to how this will interact with the session > cookie config that will come in the Tomcat 7. Thank you very much for the feedback. I believe this set of diffs much closer to what what you're looking for. I have not looked at the cookie handing in TC 7 yet, however. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
