https://issues.apache.org/bugzilla/show_bug.cgi?id=48258
--- Comment #5 from Mark Thomas <ma...@apache.org> 2009-12-01 16:42:58 GMT --- The general approach is good. Some misc comments in no particular order: - Use 4 spaces rather than tabs - Remove the changes that just add/remove whitespace at the end of a line - Some methods are missing JavaDocs - Provide the spelling corrections as a separate patch (makes things easier to review) - The new attribute needs documenting. - Some thought needs to be given to how this will interact with the session cookie config that will come in the Tomcat 7. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
