Long9725 commented on PR #914: URL: https://github.com/apache/tomcat/pull/914#issuecomment-4289511661
Thanks for the feedback. I agree that this approach introduces abstraction before there is a concrete second implementation. My intention was to make it easier to support additional compression algorithms in the future, but I understand that this may be premature at this stage. My main goal is to support multiple compression algorithms (such as Zstandard or Brotli), rather than introducing a pluggable structure upfront. For additional codecs like Zstandard, I would prefer to explore them in a separate PR, starting with a straightforward codec-specific implementation. If multiple implementations emerge, we can then revisit whether a more generic structure is warranted. If supporting additional codecs like Zstandard is not something Tomcat is aiming for, that would also be helpful to understand. Please let me know if this direction aligns better with the preferred approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
