Long9725 commented on PR #914:
URL: https://github.com/apache/tomcat/pull/914#issuecomment-4191619075
What I changed
## Pluggable factories
Introduce a list of OutputFilterFactory with default auto-registration of
gzip; add `GzipOutputFilterFactory` with level and bufferSize tunables.
- Implementation note: Http11OutputBuffer allocates activeFilters = new
OutputFilter[filterLibrary.length + 1] to allow one dynamic filter (e.g.,
negotiated compression) in addition to all library filters.
## Compression negotiation
Add quality-aware selection for TE and Accept-Encoding (highest q wins;
wildcard supported; q=0 excluded; ties resolved by server priority/index;
case-insensitive).
- Processors: Integrate negotiation in HTTP/1.1 and HTTP/2; install
negotiated filter dynamically; set headers correctly (Transfer-Encoding for TE,
Content-Encoding for Accept-Encoding); mark content length unknown when
compressing.
- EncodingNegotiator (new): Extract negotiation into a public utility with
clear rules and Javadoc; CompressionConfig now delegates directly to it.
## ETC
- Tests: Add TestEncodingNegotiator for rule-focused unit tests; keep
end-to-end negotiation/headers in
TestCompressionConfig; remove duplicated negotiation tests; fix
Accept-Encoding typo and prefer getHeader() for
TE assertions.
- Docs: Update webapps/docs/config/http.xml to document factory-based gzip
config and noCompressionEncodings; fix small typos and wrap long lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
