rmaucher commented on code in PR #834:
URL: https://github.com/apache/tomcat/pull/834#discussion_r2019045345
##########
java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java:
##########
@@ -503,7 +504,7 @@ public void init(KeyManager[] kms, TrustManager[] tms,
SecureRandom sr) throws K
}
}
// Check if the ciphers have been changed from the defaults
- if (maxTlsVersion >= TLS1_3_VERSION() &&
(sslHostConfig.getCiphers() != SSLHostConfig.DEFAULT_TLS_CIPHERS)) {
+ if (maxTlsVersion >= TLS1_3_VERSION() &&
(!Objects.equals(sslHostConfig.getCiphers(),
SSLHostConfig.DEFAULT_TLS_CIPHERS))) {
Review Comment:
The is supposed to check if the value was explicitly configured, even if it
stayed the same as the default in the end. This is for TLS 1.3 cipher suite
stuff (I'm not an expert on that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
