On Tue, Oct 22, 2024 at 10:35 AM Mark Thomas <ma...@apache.org> wrote: > > On 21/10/2024 12:55, Rémy Maucherat wrote: > > On Wed, Oct 16, 2024 at 12:14 PM Rémy Maucherat <r...@apache.org> wrote: > >> > >> Hi, > >> > >> I spent a few days going through the behavior of the WebDAV Servlet, > >> expanding on a test scenario, and looking at the most recent RFC. I > >> found many items to fix. > > > > I continued expanding the tests and found more issues to fix and > > things to refactor. The code coverage is not 100%, but is rather > > reasonable now. > > > >> Three items remain: > >> - Propatch support: it is useless without support for dead properties > >> (dead properties are custom properties, which are basically XML > >> fragments). Since storing them is a major endeavor, I would recommend > >> not implementing this. Also processing of propatch is supposed to be > >> atomic, that would be another implementation difficulty. > > > > I ended up adding an implementation since I figured I needed it to > > make sure it could work (of course, it did not). Verified with Litmus > > from github (and my own added tests). > > Did it make a change to the litmus results? If yes, which ones?
I found the bugs by writing tests to improve coverage. The specification language led to dropping the lock nulls, then rewriting shared locks since they were not done in a compliant way (maybe things were clarified). Litmus was probably misleading, since the proppatch failures were causing the tests to stop (there were no lock tests, so I found that suspicious). That would run the missing "locks" section: make URL=http://127.0.0.1:8080/examples/webdav/ TESTS="locks" check (I mapped WebDAV to /webdav/* in the examples webapp) Rémy > >> - If header support. The if header is rather convoluted, but it would > >> still be useful to have. > > > > Implemented using some of the Apache Jackrabbit code. > > > >> - Lock null has been removed from the specification and this email is > >> about that. > > > > Done. > > > > Any feedback on backporting the (big) update ? > > I think this makes sense to back port. There is enough variation in > WebDAV implementations without us adding to it. > > Mark > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
