On 06/08/2024 10:50, Konstantin Kolinko wrote:
вт, 6 авг. 2024 г. в 12:44, Mark Thomas <ma...@apache.org>:
<snip/>
I'll get those changes done.
+1
Looking at other usages of JarScannerCallback, e.g.
o.a.catalina.startup.ContextConfig, I see no obvious problem. There is
one message about DEBUG level (contextConfig.sci.info) but it is about
a different situation (whether a stacktrace is being printed), and it
is OK - it uses log.debug() there.
Update the documentation?
https://tomcat.apache.org/tomcat-11.0-doc/logging.html
a) It already mentions the "ALL" level. - OK
quote: "To enable debug logging for part of Tomcat's internals, you
should configure both the appropriate logger(s) and the appropriate
handler(s) to use the FINEST or ALL level. e.g.: "
b) There are two configuration samples (a global one, and one for the
examples web application),
quote: "Example logging.properties file to be placed in $CATALINA_BASE/conf: "
- Update to s/FINE/ALL/.
- The sample uses a FileHandler, but we are using AsyncFileHandler nowadays.
quote: "Example logging.properties for the servlet-examples web
application to be placed in WEB-INF/classes inside the web
application"
- The same as above
- ConsoleHandler is missing the ".encoding" setting.
c) BTW, in "Considerations for production usage" it says
quote: "The handlers by default use the system default encoding to
write the log files. It can be configured with encoding property. See
Javadoc for details."
I think it is still true (as it actually talks about programmed defaults),
but our default configuration has been configured to use "*.encoding =
UTF-8" on all handlers, including the ConsoleHandler.
(At the time when that phrase was written, ConsoleHandler was
configured with the system encoding.)
Thanks for the review. I've updated the docs.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
