Hi Mark,
one more thing, the shipped conf/logger.properties should also reflect the 
changes. For example it says (in 9.0.93):

# To see debug messages in TldLocationsCache, uncomment the following line:
#org.apache.jasper.compiler.TldLocationsCache.level = FINE

I would expect, that to be FINEST too...

Thanks,
  Andreas

-----Ursprüngliche Nachricht-----
Von: Mark Thomas <ma...@apache.org>
Gesendet: Dienstag, 6. August 2024 10:19
An: Tomcat Developers List <dev@tomcat.apache.org>
Betreff: TLD scanner and debug logging


WARNING: Do not click links or open attachments unless you recognize the source 
of the email and know the contents are safe.

The current TLD scanner logs the following message if JARs are scanned but not 
TLDs are found:

<quote>
At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug 
logging for this logger for a complete list of JARs that were scanned but no 
TLDs were found in them. Skipping unneeded JARs during scanning can improve 
startup time and JSP compilation time.
</quote>

However, the detailed log messages are now logged at trace level. This creates 
a couple of issues:

1. The message above is incorrect

2. With the message above corrected, and the correct logger level set, the 
messages still are not displayed because the logger handlers are configured to 
drop all messages below DEBUG level.


I'd like to propose the following changes:

- Change the default handler level to ALL. This should not change the
   current log output but should ensure messages are not dropped if a
   logger is explicitly configured to output trace (FINEST) messages.

- Change the message above to say "Enable trace logging..."


The only issue is that all the translations would need to be updated. I can 
mark them as fuzzy in POEditor which should mean they get flagged for 
review/update but whether anyone will update them is a different question. The 
alternative is to switch the TLDScanner back to logging at debug level.

Thoughts?

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional 
commands, e-mail: dev-h...@tomcat.apache.org



This message and any attachments are intended only for the use of the addressee 
and may contain information that is privileged and confidential. If the reader 
of the message is not the intended recipient or an authorized representative of 
the intended recipient, you are hereby notified that any dissemination of this 
communication is strictly prohibited. If you have received this communication 
in error, notify the sender immediately by return email and delete the message 
and any attachments from your system.

Reply via email to