On 29/11/2023 12:19, Rémy Maucherat wrote:
On Tue, Nov 28, 2023 at 4:16 PM Rémy Maucherat <r...@apache.org> wrote:
On Tue, Nov 28, 2023 at 3:18 PM Christopher Schultz
<ch...@christopherschultz.net> wrote:
Mark,
On 11/25/23 08:40, Mark Thomas wrote:
On 25/11/2023 07:59, Rémy Maucherat wrote:
On Fri, Nov 24, 2023 at 6:17 PM <ma...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit b91af3e5c32d154e26dbf8f1a19c84d301ce8e1e
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Nov 24 16:54:27 2023 +0000
Code clean - formatting. No functional change.
Primarily to reduce IDE warnings from generated code.
jextract is really bad for this. OTOH, fixing them is not practical
since they will reappear every time this is regenerated for any
reason. So could it be ignored instead ?
I did look at options for ignoring the warnings.
You can't tell Eclipse to ignore warnings in a given file/package.
We could add @SuppressWarnings("...") but that means manually editing
each file.
$ jextract ...
$ sed ...
?
Also upgrade jextract and regenerate since they do improve the output
once in a while. Clearly this is not a big priority though.
There are indeed some updates incoming:
https://github.com/openjdk/jextract/pull/145
I'll test them when they arrive.
Looks much better. Just 2 instances of ";;" rather than ";".
I can live with a couple of spurious warnings. If they do start to annoy
me, I'll fix them then.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
