On 25/11/2023 07:59, Rémy Maucherat wrote:
On Fri, Nov 24, 2023 at 6:17 PM <ma...@apache.org> wrote:

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit b91af3e5c32d154e26dbf8f1a19c84d301ce8e1e
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Nov 24 16:54:27 2023 +0000

     Code clean - formatting. No functional change.

     Primarily to reduce IDE warnings from generated code.

jextract is really bad for this. OTOH, fixing them is not practical
since they will reappear every time this is regenerated for any
reason. So could it be ignored instead ?

I did look at options for ignoring the warnings.

You can't tell Eclipse to ignore warnings in a given file/package.

We could add @SuppressWarnings("...") but that means manually editing each file.

We could disable Javadoc warnings generally but we'd need to enable equivalent checks in Checkstyle (where we can exclude files/packages) and there isn't an exact 1-2-1 mapping (at least the last time I looked).

The option I selected (use the Eclipse clean-up function with the per-defined configuration) seemed like the quickest fix.

I'm happy to run the code clean-up as and when necessary for now. If that becomes annoying, I'll look at other options. My main concern was these warnings (that I'm not concerned about) masking other warnings that I do care about.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to