Am 28.02.23 um 09:49 schrieb Mark Thomas:
On 28/02/2023 07:22, Rémy Maucherat wrote:
<ch...@christopherschultz.net> wrote:
On 2/27/23 16:09, Rémy Maucherat wrote:
On Mon, Feb 27, 2023 at 9:41 PM Mark Thomas <ma...@apache.org> wrote:
On 27/02/2023 20:36, schu...@apache.org wrote:
<snip/>
Have 'pre-release' indicate the the release is in progress.
This saves one more step in the release process.
I'm not sure we want this in a release tag. Better for it to be empty.
+1, this was on purpose.
This changes the changelog when you do "ant pre-release".
You don't want the release-tag to include "Release in progress"?
Otherwise it is just blank which is confusing IMHO.
No, it should be blank. Why would a tagged release be "in progress" ?
When people pull it later from git, it would be done.
To add some background to this.
I started to add "Release in progress" to the change log for two reasons:
- Primarily so there was something in the change log in the docs
produced by the CI for the version that was being voted on rather
than leaving it empty as that looked odd.
- Secondarily to act as a reminder to me to update the change log with
the actual release date once the vote finished. A blank release date
didn't stand out whereas this text did.
My main concern with this change is that when users download a release
and look at the change log they will see "Release in progress" for a
release that is complete. I think that is much more confusing than the
release date being left blank.
+1, it is.
The official release date is the date that the vote closes. That makes
it tricky to include in the tag as we never know exactly how long
release votes are going to last. They are typically three working days
but that is far from fixed.
I try guessing the release date for Commons Daemon and don't think I
have ever got it right. I end up correcting the release date of the N-1
release in the N release which I think is potentially even more confusing.
Overall, my preference is that:
- we leave the release date blank in the tag for that release
- we update HEAD to "Release in progress" for that version while voting
(probably at the same time as we increment the version number for the
next development cycle)
- we update HEAD to the actual release date (or "Not released") for that
version once the vote completes
+1
There would certainly be some benefit to automate the second step in the
process as a post release task in Ant.
Sure.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
