On Tue, Feb 28, 2023 at 1:46 AM Christopher Schultz
<ch...@christopherschultz.net> wrote:
>
> Mark and Remy,
>
> On 2/27/23 16:09, Rémy Maucherat wrote:
> > On Mon, Feb 27, 2023 at 9:41 PM Mark Thomas <ma...@apache.org> wrote:
> >>
> >> On 27/02/2023 20:36, schu...@apache.org wrote:
> >>> This is an automated email from the ASF dual-hosted git repository.
> >>>
> >>> schultz pushed a commit to branch 10.1.x
> >>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >>>
> >>>
> >>> The following commit(s) were added to refs/heads/10.1.x by this push:
> >>> new 3e08c2790c Have 'pre-release' indicate the the release is in
> >>> progress.
> >>> 3e08c2790c is described below
> >>>
> >>> commit 3e08c2790c2eb42e1692841d333ad71f53377086
> >>> Author: schultz <schu...@apache.org>
> >>> AuthorDate: Mon Feb 27 12:35:49 2023 -0800
> >>>
> >>> Have 'pre-release' indicate the the release is in progress.
> >>>
> >>> This saves one more step in the release process.
> >>
> >> I'm not sure we want this in a release tag. Better for it to be empty.
> >
> > +1, this was on purpose.
>
> This changes the changelog when you do "ant pre-release".
>
> You don't want the release-tag to include "Release in progress"?
> Otherwise it is just blank which is confusing IMHO.
No, it should be blank. Why would a tagged release be "in progress" ?
When people pull it later from git, it would be done.
> Whenever I do a release, I put "Release in progress" into the rtext in
> the changelog. I can stop doing that if you would prefer.
Rémy
>
> -chris
>
> >>> ---
> >>> build.xml | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/build.xml b/build.xml
> >>> index 27ba36423b..10c63b480f 100644
> >>> --- a/build.xml
> >>> +++ b/build.xml
> >>> @@ -2759,7 +2759,7 @@ asf.ldap.username=${release.asfusername}
> >>> <replace file="webapps/docs/changelog.xml"
> >>> encoding="UTF-8"
> >>> token="rtext="in development""
> >>> - value="rtext=""" />
> >>> + value="rtext="Release in progress"" />
> >>> </target>
> >>>
> >>> <target name="release"
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >>> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
