[tomcat] branch 10.1.x updated: Update false positives

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
     new 86926940b6 Update false positives
86926940b6 is described below

commit 86926940b6229f191262a62c7ab0b94889e5584b
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Feb 16 16:39:21 2023 +0000

    Update false positives
---
 res/spotbugs/filter-false-positives.xml | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/res/spotbugs/filter-false-positives.xml 
b/res/spotbugs/filter-false-positives.xml
index ac7915b632..e377cdcbd1 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -305,6 +305,11 @@
     </Or>
     <Bug code="DE" />
   </Match>
+  <Match>
+    <!-- Unit test confirms public no-arg constructor is not required -->
+    <Class name="org.apache.catalina.ha.session.DeltaRequest$AttributeInfo" />
+    <Pattern code="SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION" />
+  </Match>
   <Match>
     <!-- False positive caused by additional method syncs -->
     <Class name="org.apache.catalina.ha.session.DeltaManager" />
@@ -754,6 +759,12 @@
     <Field name="current"/>
     <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
   </Match>
+  <Match>
+    <!-- Not an issue. Initialisation is as intended. -->
+    <Class name="org.apache.catalina.tribes.util.JreCompat"/>
+    <Method name="&lt;clinit&gt;"/>
+    <Bug pattern="IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION" />
+  </Match>
   <Match>
     <!-- Random is SecureRandom and will be used multiple times. -->
     <Class name="org.apache.catalina.tribes.util.UUIDGenerator"/>
@@ -2250,6 +2261,12 @@
     <Method name="&lt;clinit&gt;" />
     <Bug pattern="DMI_HARDCODED_ABSOLUTE_FILENAME"/>
   </Match>
+  <Match>
+    <!-- Deliberate hack for the purposes of the test -->
+    <Class name="org.apache.coyote.TestIoTimeouts$EchoListener"/>
+    <Field name="t"/>
+    <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
+  </Match>
   <Match>
     <!-- Deliberate hack for the purposes of the test -->
     <Class 
name="org.apache.coyote.http11.filters.TestChunkedInputFilter$BodyReadServlet"/>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org