This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 3f7dafd902 Update false positives
3f7dafd902 is described below
commit 3f7dafd902a0c81475e7dd8478a6deb3fac6216c
Author: Mark Thomas <[email protected]>
AuthorDate: Thu Feb 16 16:24:36 2023 +0000
Update false positives
---
res/spotbugs/filter-false-positives.xml | 27 ++++++++++++++++++++++-----
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/res/spotbugs/filter-false-positives.xml
b/res/spotbugs/filter-false-positives.xml
index ba87039f5f..71b02b0771 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -305,6 +305,11 @@
</Or>
<Bug code="DE" />
</Match>
+ <Match>
+ <!-- Unit test confirms public no-arg constructor is not required -->
+ <Class name="org.apache.catalina.ha.session.DeltaRequest$AttributeInfo" />
+ <Pattern code="SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION" />
+ </Match>
<Match>
<!-- False positive caused by additional method syncs -->
<Class name="org.apache.catalina.ha.session.DeltaManager" />
@@ -2005,6 +2010,15 @@
<Method name="onDataAvailable"/>
<Bug pattern="RR_NOT_CHECKED"/>
</Match>
+ <Match>
+ <!-- Test class not intended to be serialized -->
+ <Class
name="org.apache.catalina.nonblocking.TestNonBlockingAPI$NBWriteWithCloseServlet"/>
+ <Or>
+ <Field name="afterCloseLatch"/>
+ <Field name="beforeCloseLatch"/>
+ </Or>
+ <Bug pattern="SE_BAD_FIELD"/>
+ </Match>
<Match>
<!-- Not single use -->
<Class name="org.apache.catalina.startup.FastNonSecureRandom"/>
@@ -2251,11 +2265,14 @@
</Match>
<Match>
<!-- Deliberate hack for the purposes of the test -->
- <Class
name="org.apache.coyote.http11.filters.TestChunkedInputFilter$BodyReadServlet"/>
- <Or>
- <Field name="countRead"/>
- <Field name="exceptionDuringRead"/>
- </Or>
+ <Class name="org.apache.coyote.TestIoTimeouts$EchoListener"/>
+ <Field name="t"/>
+ <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
+ </Match>
+ <Match>
+ <!-- Deliberate hack for the purposes of the test -->
+ <Class
name="org.apache.coyote.http11.filters.TestChunkedInputFilter$EchoHeaderServlet"/>
+ <Field name="exceptionDuringRead"/>
<Bug pattern="MSF_MUTABLE_SERVLET_FIELD"/>
</Match>
<Match>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
