DanielThomas commented on PR #37: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1294527488
I omitted those so: - A move from `jakarta` -> `javax` would only relocate the classes provided by 1.3, leaving the later ones alone - Especially avoids touching `Nonnull`/`Nullable` because `Nullable` from JSR-305 implements parameters and a `Checker` that can't be satisfied by other implementations: ``` package javax.annotation; import java.lang.annotation.Documented; import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; import javax.annotation.meta.TypeQualifier; import javax.annotation.meta.TypeQualifierValidator; import javax.annotation.meta.When; /** * The annotated element must not be null. * <p> * Annotated fields must not be null after construction has completed. * <p> * When this annotation is applied to a method it applies to the method return value. */ @Documented @TypeQualifier @Retention(RetentionPolicy.RUNTIME) public @interface Nonnull { When when() default When.ALWAYS; class Checker implements TypeQualifierValidator<Nonnull> { public When forConstantValue(Nonnull qualifierArgument, Object value) { if (value == null) return When.NEVER; return When.ALWAYS; } } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org