DanielThomas commented on PR #37:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1294468210
Definitely better - moving only `tomcat-annotations-api` avoids touching a
bunch of files that don't actually need a migration. Guava is completely
untouched by using an inclusion list:
```
Migration starting for archive [guava-31.1-jre.jar] using streaming
Migration finished for archive [guava-31.1-jre.jar]
Migration completed successfully in [540] milliseconds
```
If I migrate `tomcat-annotations-api` to confirm coverage the only thing I
notice is the parent directories aren't touched, but that doesn't affect
classloading. I'd guess this isn't a concern, because the parent `javax`
directory already isn't handled prior to this change, so it's already depending
on the directory entry not being a dependency of extracting correctly.
Before:
```
Length Date Time Name
--------- ---------- ----- ----
0 08-08-2022 07:26 META-INF/
411 08-08-2022 07:26 META-INF/MANIFEST.MF
0 08-08-2022 07:26 javax/
0 08-08-2022 07:26 jakarta/annotation/
0 08-08-2022 07:26 jakarta/annotation/security/
0 08-08-2022 07:26 jakarta/annotation/sql/
680 08-08-2022 07:26 jakarta/annotation/Generated.class
...
```
After:
```
Length Date Time Name
--------- ---------- ----- ----
0 08-08-2022 07:26 META-INF/
411 08-08-2022 07:26 META-INF/MANIFEST.MF
0 08-08-2022 07:26 javax/
0 08-08-2022 07:26 javax/annotation/
0 08-08-2022 07:26 javax/annotation/security/
0 08-08-2022 07:26 javax/annotation/sql/
680 08-08-2022 07:26 jakarta/annotation/Generated.class
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
