wmccusker commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r955189029
########## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ########## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static org.junit.Assert.assertTrue; Review Comment: Yes, that is the general recommendation for why static imports are not used. In this specific case, it is a very common and accepted practice that the Assert class from Junit is imported using a static import. As mentioned before, the static import is consistent with all the existing Junit test code in this project. Are you suggesting that this single Junit test should break with the consistency of how all the other Junit tests are written? That only this unit test should do something different than all the other unit test code that is already in the repository? Using a non-static import, in this case, would be less intuitive because it would introduce two different conventions for how the Asset class is handled in unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
