aooohan commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r954498342
########## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ########## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static org.junit.Assert.assertTrue; Review Comment: You're right, But the reason it's not recommended is that it's not very intuitive because we don't know if it's a junit method or a custom method when the test has many code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
