https://bz.apache.org/bugzilla/show_bug.cgi?id=62611
--- Comment #11 from HanLi <aooo...@gmail.com> --- (In reply to Christopher Schultz from comment #10) Hi Christopher, > The quality of this patch/PR is low. Several unresolved comments have been > made on the PR already. > > There isn't any proper resource-management. I mean that i will fix this unresovled comments based on some advices. > > The CompressFileUtils class appears to be added twice under two separate > packages (why the duplication?). I found this too,and i think the reason for this is only known to the author himself,and i will keep just one. > > I have to ask again why this is being added as a feature of the > AccessLogValve and not just sending access logs to a proper logging > framework which already supports compression, rotation, etc.? I aggree with you that using a logging framework that support these festures is the better way. But i have a question that this feature is not supported by AccessLogValve, it need user to implement AbstractAccessLogValve to support the function of sending logs to other logging frameworks，right? -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
