https://bz.apache.org/bugzilla/show_bug.cgi?id=62611

--- Comment #10 from Christopher Schultz <ch...@christopherschultz.net> ---
The quality of this patch/PR is low. Several unresolved comments have been made
on the PR already.

There isn't any proper resource-management.

The CompressFileUtils class appears to be added twice under two separate
packages (why the duplication?).

I have to ask again why this is being added as a feature of the AccessLogValve
and not just sending access logs to a proper logging framework which already
supports compression, rotation, etc.?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to