On 16/05/2022 18:54, Christopher Schultz wrote:
I had considered using ant.tstamp.now.iso (you can see I had it in the
patch, actually), but I think it changes the required version of ant for
building. Since this is expected to be used by Tomcat release-managers
only, I think that's a reasonable requirement to put on the ant version.
We may want to put some checks into the build so ensure that if
ant.tstamp.now.iso is set, you have a version of ant which is high
enough to respect it and terminate the build if necessary.
WDYT?
Ant 1.10.x requires Java 8 (rather than Java 5). I'm fine with that
being a requirement for anyone building Tomcat.
I haven't played with it in a while, but I seem to recall that if you
execute "pre-release" and "release" at the same time (like "ant
pre-release release"), weird things happen with the timestamp. Also if
you do "pre-release" after having run "pre-release" you get some
weirdness. I think. I'll have to go back and look :)
We might want to hide a few targets. I suspect they were made visible
just so they could be tested during development.
Finally, "clean" should probably remove the build-release.properties file.
That could be problematic. The release target depends on the clean target.
I think we might need another property that triggers generation of the
file if not present. That way, release managers can set that property on
their release systems but it won't get in the way of anyone else using
"ant release".
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
