Mark,
On 5/16/22 12:30, Mark Thomas wrote:
On 06/05/2022 14:27, Christopher Schultz wrote:
Awesome. I have a small commit to build.xml that drops environmental
information (e.g. versions, etc.) to a build-release.properties file,
but I'm unable to generate the timestamp in the correct format in
order to put it into the file. Here's the patch for it; I'd love it if
anyone could help solve the problem.
Thanks for providing the patch.
I used it as the basis of for an update to my reproducible branch where
I have the other changes waiting for the updated BND release.
I managed to solve the format problem by working with ant.tstamp.now.iso
rather than ant.tstamp.now. The iso format was relatively simple to
generate and, as long as you generate a timestamp for UTC, Ant can read it.
I had considered using ant.tstamp.now.iso (you can see I had it in the
patch, actually), but I think it changes the required version of ant for
building. Since this is expected to be used by Tomcat release-managers
only, I think that's a reasonable requirement to put on the ant version.
We may want to put some checks into the build so ensure that if
ant.tstamp.now.iso is set, you have a version of ant which is high
enough to respect it and terminate the build if necessary.
WDYT?
I'll commit all these changes once BND 6.3.0 is available - hopefully in
time for the next release round.
Cool.
I haven't played with it in a while, but I seem to recall that if you
execute "pre-release" and "release" at the same time (like "ant
pre-release release"), weird things happen with the timestamp. Also if
you do "pre-release" after having run "pre-release" you get some
weirdness. I think. I'll have to go back and look :)
Finally, "clean" should probably remove the build-release.properties file.
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
