https://bz.apache.org/bugzilla/show_bug.cgi?id=64875

--- Comment #6 from mgrigorov <mgrigo...@apache.org> ---
(In reply to Remy Maucherat from comment #5)
> (In reply to mgrigorov from comment #2)
> > I've made it possible to use APR protocol.
> > There is nothing Netty specific in it.
> > As Remy explained you need to find out how Netty is being involved and why
> > it breaks the things.
> 
> I also cannot see where Netty could possibly be coming from, it's 100% not
> used in Tomcat, so it comes from a library somewhere else.
> 
> However, I don't understand the idea behind advocating use of the APR
> connector especially in embedded. The plan is still to remove it completely
> at the moment.

It is not advocating anything. It just fixed a broken use case. All other
protocols (NIO and NIO2) worked out of the box. APR was failing with
"Unsupported JNI version 0xffffffff".
org.apache.coyote.http11.Http11AprProtocol is not deprecated in even in master
branch, so I just fixed the problem.

> 
> With the standalone native image build, I tested NIO/OpenSSL, but APR is not
> supported at all in the descriptors. And even NIO/OpenSSL brings along all

What do you mean with "APR is not supported in the descriptors" ?
After adding tomcat-jni.json I was able to use APR protocol without any other
problems.

> the build/runtime problems with containers. Since now even Java 8 does ALPN
> properly, I would say it is more reasonable to stick to the base JVM
> whenever possible.


I don't mind removing "-H:JNIConfigurationResources=${.}/tomcat-jni.json" from 
https://github.com/apache/tomcat/blob/da3b672ed6b59afbc6341c2bb00aad435bcf7a9b/res/graal/tomcat-embed-core/native-image/native-image.properties#L16
But let's keep tomcat-jni.json in META-INF/... This way if anyone wants to use
APR (s)he will be able to refer to it in his/her native-image build parameters.
Is this OK for everyone ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to