kamnani commented on pull request #352:
URL: https://github.com/apache/tomcat/pull/352#issuecomment-696930075


   > There's no cache here: the AbstractArchiveResourceSet already has a 
"JarFile archive" field, so it adds a new JarContents field with the same data 
and both get created and cleared at the same time. Looking back at the other 
#340 there were problems with the loader/classloader modifications which IMO 
look like a big hack and have a JAR cache.
   
   I think, your solution does make sense to me. I will still need these code 
lines in AbstactArchiveResourceSet just to skip checking a jar if the resource 
is not going to be found there. 
   
   ```
      if (!jarContents.mightContainResource(path, webAppMount)) {
                       return new EmptyResource(root, path);
                   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to