rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696769628
I made the change to use the Context instead of the Host, no issue there. However, I'm not ok with the proposed changes as is. The problem for me is that I don't understand the weird code added to AbstractArchiveResourceSet. I am ok with adding the creation of that JarContents filter in openJarFile() [even with the sync ...], basically, but not elsewhere, and without the strange custom refresh mechanism on lookup. Then, since it is *likely* quite harmless, it could be enabled by default (and maybe the flag can be removed altogether ...). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
