On 29/04/2020 17:49, Christopher Schultz wrote: > Mark, > > On 4/28/20 14:03, Mark Thomas wrote: >> On 28/04/2020 15:22, Christopher Schultz wrote: >>> All, >>> >>> I'd like a review of the test-case I wrote for the multipart >>> config stuff. >>> >>> It *works*, but perhaps there are better ways to do the things >>> that I did. >>> >>> Someone who is more familiar with all the various ways of >>> testing Tomcat would probably be able to replace some of my hacks >>> with something a little more straightforward. > >> I don't see anything that jumps out at me as needing to be >> changed. > > Excellent, thanks. Using reflection to force my way into those private > methods seemed a little ugly. I'm not familiar enough with the rest of > the unit tests to know if that's an often-used technique or if there > was a better way of exposing the internals for a unit-test.
You could make the relevant methods package private but personally I dislike that more than reflection in the tests. YMMV. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
