-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark,
On 4/28/20 14:03, Mark Thomas wrote: > On 28/04/2020 15:22, Christopher Schultz wrote: >> All, >> >> I'd like a review of the test-case I wrote for the multipart >> config stuff. >> >> It *works*, but perhaps there are better ways to do the things >> that I did. >> >> Someone who is more familiar with all the various ways of >> testing Tomcat would probably be able to replace some of my hacks >> with something a little more straightforward. > > I don't see anything that jumps out at me as needing to be > changed. Excellent, thanks. Using reflection to force my way into those private methods seemed a little ugly. I'm not familiar enough with the rest of the unit tests to know if that's an often-used technique or if there was a better way of exposing the internals for a unit-test. - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl6psB0ACgkQHPApP6U8 pFi5NhAAsyYBPv2QefM2iIFZhr8/3GnIaoCGLsslx2WNUJStj9RMVEPoJ4pa9EZ0 zxgIUPY7t4RFQ993WzntrK43JNPqS5cQ2U+KhfL86VbHGhl5Ka3ypfZLLQkPT1ER dwJI4bE8Lp8MyRR7GuxJbLmLUmWzTBEXpxwMcBrATKQQmIkaF30fwCiTVJdWpF78 LoKYd7yHuvH4EWUWGqMpaUoRzUW5dvXA66tzfOPic2/6hTk+cghQt1Hu5M+/jjjI sRXlle2P1TfTKc96Wr4i+hMiK7KbHKgbkPX9UHhagdE109Ldxqspk0mR4E3mR2gs yHB1KTbLO5sxQcDuP/uuyM+1u7pyIDTkNTlzvEQfQaPd91FzWOpXZNFxwxRozbXH E3Ftfj9ESHf390YKT0EmlG2x96PDkLHglRy0ooZTMn32GziY2u0wFXhrRVswTnVk WDjYxJi7MK+vFL5OzFOFLMK0UBWc13iLU3TGpsudlf0bt9eSALG/7RPdgXxtTOJl K7SQu0BqzTakS6eT/CFMjyIZfxPhwHsKOau+Dni70ZHOTs6rEOvVsTok2eDTWvdD F421+sIstucFJIKLfbaivMiIUumPZCs9bgkeTJ5DfwQUJsIXN+GgVjCkGaStL+MO 6SzQbhg6LkiHQm1MWL5hwKGN3Q5WOKXDOmXVlwGoYybbq8IOMNk= =RIEq -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
