On Tue, Feb 11, 2020 at 4:49 PM Mark Thomas <ma...@apache.org> wrote:
> On 11/02/2020 15:29, Martin Grigorov wrote: > > > > > > On Tue, Feb 11, 2020, 17:12 Mark Thomas <ma...@apache.org > > <mailto:ma...@apache.org>> wrote: > > > > On 11/02/2020 14:49, Martin Grigorov wrote: > > > Hi, > > > > > > What is the proper place to report issues > > > with https://github.com/apache/tomcat-jakartaee-migration ? > > > Since it is under `apache` org there is no 'Issues' tab. > > > Bugzilla ?! > > > > We don't have anywhere yet. > > > > GitHub issues is an option. As is Jira and Bugzilla. > > > > This could be an opportunity to experiment with GitHUb issues if we > > want. > > > > > > For this we need to ask Infra team. > > Well, yes and no given that I am on the infra team... > > If we want to try it I can enable it. > > > > Don't you want to do something like: > > > > destEntry.setMethod(jarEntry.getMethod); > > > > > > If the method is STORED then we also need to set the size and the CRC. > > And those are more complicated to get. > > Ah. I didn't see anything about that being required in the Javadoc for > setMethod(). > > Looking at the source for ZipOutputStream it looks like we need 1 of > compressed size, size or CRC. Of those, I would have thought the size > was the easiest as we should be able to count the bytes written. > Setting the size sounds mundane but is rather horrible to implement, as the migration occurs after creating the entry. So it suddenly needs to be buffered, causing more problems. I don't think it should be supported. Rémy
