On Tue, Feb 11, 2020, 17:12 Mark Thomas <ma...@apache.org> wrote: > On 11/02/2020 14:49, Martin Grigorov wrote: > > Hi, > > > > What is the proper place to report issues > > with https://github.com/apache/tomcat-jakartaee-migration ? > > Since it is under `apache` org there is no 'Issues' tab. > > Bugzilla ?! > > We don't have anywhere yet. > > GitHub issues is an option. As is Jira and Bugzilla. > > This could be an opportunity to experiment with GitHUb issues if we want. >
For this we need to ask Infra team. > > I've faced an issue with Spring Boot jars. > > Once migrated trying to use it fails with: > > <snip/> > > > Caused by: java.lang.IllegalStateException: Unable to open nested entry > > 'BOOT-INF/lib/spring-boot-starter-web-2.2.4.RELEASE.jar'. It has been > > compressed and nested jar files must be stored without compression. > > Please check the mechanism used to create your executable jar file > > Of course. That is a trick Spring Boot uses to provide better > performance for nested JAR files. > > > i.e. it needs to use `destEntry.setMethod(ZipEntry.STORED);` (for jars > > nested in /BOOT-INF/lib/**.jar) > > in org.apache.tomcat.jakartaee.Migration#migrateArchive() > > I am reworking it to return a Result object instead of a boolean > > (isSuccess) that will contain: the > > isSuccess boolean, the accumulated size and CRC for all entries in the > > nested jar. > > > > If I am on the wrong track please share your ideas! > > The CRCs are always going to be different because the content has changed. > > The accumulated sizes are going to change for the same reason. > > In terms of being able to tell compressed / vs uncompressed I'm not sure > you'll see enough difference (given that a JAR is already compressed > with probably the exact same algorithm) to tell them apart. > > Don't you want to do something like: > > destEntry.setMethod(jarEntry.getMethod); > If the method is STORED then we also need to set the size and the CRC. And those are more complicated to get. > around line 119 of Migration.java ? > > Mark > > > > > > To reproduce it one can create a new application > > at https://start.spring.io/, package it, migrate it and try to run it. > > > > Martin > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
