On 06/12/2019 17:48, Christopher Schultz wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Mark, > > On 12/6/19 12:12, Mark Thomas wrote: >> On 06/12/2019 16:52, Christopher Schultz wrote: >> >> <snip/> >> >>> Let me know if that's all good. >> >> Thanks. >> >> Looks good to me from a quick scan. >> >> I'll let the CI system run as it does a Maven deploy of a snapshot >> so we should be able to use that to check the Maven artefacts. >> >> Scratch that. The CI has already run. Looks like it built. Woot! >> >> Only query is the POM correct for dependencies? The OSGI >> import/export package info BND added to the manifest doesn't agree >> with the POM. > > Which parts? I'm not sure what I'm looking for. > > tomcat-ssi.pom contains the wrong <description> -- I copied from > tomcat-tribes and forgot to change that, so I'll fix that.
Thanks. I didn;'t even see that. > BND contains: > > Bundle-Name: tomcat-ssi > Bundle-SymbolicName: org.apache.tomcat-ssi > Bundle-Version: @VERSION@ > Export-Package: \ > org.apache.catalina.ssi More stuff gets added to that during the build and placed in the manifest. > POM contains: > > <artifactId>tomcat-ssi</artifactId> > > Oh. My POM looks like it's missing a bunch of things such as a > dependency on Tomcat itself. I believe we need: > > tomcat-catalina > tomcat-util > tomcat-coyote > > (I'd like to work to remove that last one soon if possible.) > > Just add those to the POM? Correct. There is a dependency on the servlet API too but we'll get that via the deps you've already listed. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
