-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Mark,
On 12/6/19 12:12, Mark Thomas wrote:
> On 06/12/2019 16:52, Christopher Schultz wrote:
>
> <snip/>
>
>> Let me know if that's all good.
>
> Thanks.
>
> Looks good to me from a quick scan.
>
> I'll let the CI system run as it does a Maven deploy of a snapshot
> so we should be able to use that to check the Maven artefacts.
>
> Scratch that. The CI has already run. Looks like it built. Woot!
>
> Only query is the POM correct for dependencies? The OSGI
> import/export package info BND added to the manifest doesn't agree
> with the POM.
Which parts? I'm not sure what I'm looking for.
tomcat-ssi.pom contains the wrong <description> -- I copied from
tomcat-tribes and forgot to change that, so I'll fix that.
BND contains:
Bundle-Name: tomcat-ssi
Bundle-SymbolicName: org.apache.tomcat-ssi
Bundle-Version: @VERSION@
Export-Package: \
org.apache.catalina.ssi
POM contains:
<artifactId>tomcat-ssi</artifactId>
Oh. My POM looks like it's missing a bunch of things such as a
dependency on Tomcat itself. I believe we need:
tomcat-catalina
tomcat-util
tomcat-coyote
(I'd like to work to remove that last one soon if possible.)
Just add those to the POM?
- -chris
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl3qlIEACgkQHPApP6U8
pFjOiBAAyd8FOqWSPAiXAnaz3p28MUNFpMJsq5TH9QIBz8DHJChXDbs5QjjsKMT+
hlNsqfYF28wmy1JVBPuDrbN/XDCkWnm84cDIqNcvrUEgngWjEwoz8zbDYT/bQgBz
RqAEKG8Oh5nWsaO4qjXSFltyrp8IG2p+m+RaoOx9l8vhG6jsZYaRY+DJfgBj6l3m
h4rLOmvQ2XTDpd3RWAeM+3+UoqZ7e74SQbtCuEAgC9e1lAyU65yq3o9hivoUeuHi
xrMptzE+ldrcccLJHqOhvXYovMxLOFs2Rv/iuz3cQ7qJoFrM5MNJAgEg6IMEF7R2
hZEivFNsjwtF/EfBXqsyy+apD6TyE7sG72hA7Sl9xMud01Gb98FU8PJjEWGZ4BDy
t97yAs02g18L6Dnd+PF4MNsCMwevbB/2Jvwn3rW3U3vQbEk2km7EaB2eUb6s2mRF
4pee3iZUqJ3fhpVRNpgQkIurtWxlrBHNyLTgj94Onx+53oUwcvFFwh6peq3FIuMr
JggvXSarEASMr0iLMsMLAsuMN2a1cPnVa9rHCBgnZMHh4YHA+E5meOXGueDbr7Nr
PnCEMvm17xQhhZNqGBsEOKniV39dtxd7i2MoS5RjEQrxTlH9Dy558gIsLthRDfN4
11D5LVD5APKBk8A598Ts5nD5U6wdoD1IJnI39S72nDsiW6Gh9HY=
=HkYW
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
