On 12/02/2019 23:10, Christopher Schultz wrote: > Mark, > > On 2/12/19 08:55, Mark Thomas wrote: >> Hi, > >> Tomcat 7 depends on DBCP 1.x and POOL 1.x. The last release of each >> of these was in 2013. There are a number of fixes I would like to >> be able to pull into Tomcat 7 - including the fix for BZ 58338. > >> There is little/no appetite in the Commons community to release >> DBCP 1.x or Pool 1.x. > >> Having tried to get releases out via the release process Commons >> uses, I have no desire to try and get these releases out myself. > >> It would greatly simplify things if 7.0.x took the same approach to >> DBCP and Pool as 8.5.x and 9.0.x and maintained a local fork of the >> code. > >> Like the fork of DBCP 2.x and Pool 2.x, changes would be made in >> commons and the Tomcat fork updated. The only local changes would >> be the package re-naming and and changes required to keep >> checkstyle and FindBugs happy (and some of those may get made in >> Commons first). > >> I therefore propose to import the DBCP/Pool 1.x source into Tomcat >> 7.x following the same pattern as for DBCP/Pool 2.x in 8.5.x. > >> If there are no objections, I'll probably do this late this week >> early next. > > Is there any appetite for maintaining patches-only and > merging-on-build? It would mean a smaller repo for us not just in > terms of size (which is largely irrelevant) but also in terms of > brain-cycles. > > If I can see that we patch pool-1.x with a 5-line change and add a > sour\ce file versus there are 500 source files in there that all need > to be diff'd against their original sources, it makes it easier for > anyone to look at the code to see what's happening. > > It does complicate the release process, though.
Speaking as the one volunteering to doing the work, there is no appetite for that here. For me, at least, it is more work. I'm expecting it to be more like 100 files as we only want the sources. The diff isn't an issue. We do it for DBCP2 and friends in 9.0.x/8.5.x and it is easy to do a quick visual check of the diff. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
