On Mon, Jan 14, 2019 at 12:27 PM Konstantin Kolinko <knst.koli...@gmail.com> wrote:
> ср, 9 янв. 2019 г. в 20:10, Rémy Maucherat <r...@apache.org>: > > > > Hi, > > > > So I'm looking at random small items as possible cleanups and ... The > > extras came up. > > > > At some point (15 years ago) the idea was to have a smaller JAR and avoid > > bloat, but right now I don't see the point of keeping them out of the > > regular catalina.jar (and thus reduce the complexity of the build a bit): > > - a listener to configure JMX remote (possibly not as useless as it > sounds > > for cloud stuff even though they like their Jolokia since it's json) > > - some webservices naming factory (ok, so I guess it's not very useful, > but > > only +15kB or so) > > > > Did I miss something ? > > > > 1. I think there was a discussion to move CGI and SSI servlet/filter > into extras (or to delete them). > > Nothing pressing here. I do not mind those servlets being present in > catalina.jar. > Personally, I'd like to keep kludges likes extras out from now on, because the stuff there is forgotten. Separate JARs should be used for separate components, and if useless they should be removed. > > 2. I am OK with the changes that you did (moving the classes into > catalina.jar). > > Dropping maven artifacts: > some Maven users may be surprised by this, but I think that they can > adapt easily. > I am OK with this. > Yes, it's very easy to change for users. > > The documentation needs update as well. > E.g. documentation for JmxRemoteLifecycleListener [1] (nightly docs > build for 9.0) still mentions catalina-jmx-remote.jar. > > [1] > https://ci.apache.org/projects/tomcat/tomcat9/docs/config/listeners.html#JMX_Remote_Lifecycle_Listener_-_org.apache.catalina.mbeans.JmxRemoteLifecycleListener Thanks, I fixed the issue, it's a good idea to not keep the doc outdated. Rémy > > > Best regards, > Konstantin Kolinko > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
