On 07/08/2018 09:47, Mark Thomas wrote:
On 07/08/18 09:42, jean-frederic clere wrote:
On 07/08/18 10:10, Mark Thomas wrote:
On 07/08/18 08:55, jean-frederic clere wrote:
Hi,
I just want to ask what is the process, we pick all changes after
commons-dbcp releases a version, or could I pick the actual code?
Generally, I keep an eye on DBCP2/Pool2 and pick up the changes from
master after I see an issue fixed I think might affect Tomcat users.
DBCP2 has recently added support for later JDBC versions so we may need
to be careful exactly which branch we pull from going forwards. I'd made
a mental note to figure out what we needed to do but hadn't got around
to it.
Someone is chasing me for DBCP-514, DBCP-515 and DBCP-516 that is why I
am asking.
commons-dbcp released 2.5.0 which doesn't have those fixes and we are
based on 2.4.0 in trunk.
So depending on your investigations we may or may not update to 2.6.0
once it is released, correct?
I think we'll update to 2.6.0. The question is what do we do if the
addition of the later JBDC methods causes us issues. I think we'll just
need to remove the @Override annotations. If that doesn't work (I can't
think why it wouldn't we'll need to remove some methods.
I'll make sure these updates make it into the next round of Tomcat releases.
9.0.x was fine and is updated to the latest DBCP code from master.
8.5.x is a little more tricky. The JDBC 4.2 (Java 8) changes were more
problematic.
There were changes to Statement, Result etc. that could not be
back-ported. Well, they could have been with a *lot* of reflection but
it would have been pretty messy.
There was also a new class SQLType used in those methods that would have
meant more reflection.
In the end, I opted to updated to the latest DBCP 2 code and then delete
the problematic (JDBC 4.2) methods. If someone wants to explore the
reflection route, it is trivial to do a diff between 9.0.x and 8.5.x,
restore the deleted methods and then figure out a way to implement them
that works for Java 7+.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
