On Thu, Mar 29, 2018 at 10:31 PM, Mark Thomas <ma...@apache.org> wrote:
> On 29/03/18 20:58, Mark Thomas wrote: > > On 29/03/18 14:39, Christopher Schultz wrote: > >> On 3/29/18 9:30 AM, Rémy Maucherat wrote: > >>> On Thu, Mar 29, 2018 at 3:15 PM, Christopher Schultz < > >>> ch...@christopherschultz.net> wrote: > >>>> On 3/29/18 8:42 AM, Rémy Maucherat wrote: > >>>>> On Thu, Mar 29, 2018 at 2:33 PM, Christopher Schultz < > >>>>> ch...@christopherschultz.net> wrote: > >>>>>> On 3/28/18 2:25 PM, Rémy Maucherat wrote: > >>>>>>> Hi, > >>>>>>> > >>>>>>> In Tomcat, DBCP2 is missing the XA portion (all contained in a > single > >>>>>>> "managed" package). So at work I now got some people asking about > that > >>>>>>> removal, and that's always a bit annoying as they have to go to a > >>>>>> separate > >>>>>>> vanilla DBCP2 to get the functionality. Annoying sometimes. > >>>>>>> > >>>>>>> So it would be possible to add the classes in Tomcat (including the > >>>>>>> javax.transaction to build, as that's the Tomcat way to deal with > >>>> that), > >>>>>>> even though the user would need to add its own transaction manager > to > >>>> do > >>>>>>> anything with it. > >>>>>>> > >>>>>>> Should I now add it (only in 9/trunk) or instead leave things the > way > >>>>>> they > >>>>>>> are ? Both work to be honest, it's just that I've been bitten by > the > >>>> "we > >>>>>>> only ship 3/4 of DBCP and I didn't know it" bug. > > Sorry. I meant to reply to this bit as well but forgot. > > From memory I left it out on the basis few people needed it and that we > could always add it in later if there was demand. > > There appears to be demand so no objections here to adding that code. > > Ok, so if nobody complains, I'll add the classes today [based on the 8a71764 revision that was integrated in 9.0.3], this will make my usecase better. I had to make the casual cleanups to pass Tomcat's checkstyle, should that be contributed to DBCP ? Rémy
