2018-06-20 22:45 GMT+03:00 Mark Thomas <ma...@apache.org>: > The proposed Apache Tomcat 9.0.10 release is now available for voting. > > The proposed 9.0.10 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 9.0.10
1. Smoke testing: OK 2. Unit tests (Java 8u172 32-bit x All connectors): OK, but two issues 1). full run running serially was 5 hours (297 minutes), and 1 hour of that was wasted by a single test, running for 20 minutes * 3 connectors: javax.websocket.TestContainerProviderPerformance For a record, output from the test for one connector (for the two others the numbers are essentially the same): [[[ Testsuite: javax.websocket.TestContainerProviderPerformance Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1 178,873 sec ------------- Standard Output --------------- 1 threads completed in 55755044684ns 2 threads completed in 61728387735ns 3 threads completed in 93829730333ns 4 threads completed in 128505257668ns 5 threads completed in 162278174598ns 6 threads completed in 193964829070ns 7 threads completed in 225423312232ns 8 threads completed in 257262194348ns ------------- ---------------- --------------- Testcase: testGetWebSocketContainer took 1 178,81 sec ]]] I saw that there was an e-mail thread discussing this test (and similar) on May 11th https://tomcat.markmail.org/thread/q3csgi2e5ieexuap 2) org.apache.tomcat.jni.TestSocketServer fails for all connectors. [concat] Testsuites with failed tests: [concat] TEST-org.apache.tomcat.jni.TestSocketServer.APR.txt [concat] TEST-org.apache.tomcat.jni.TestSocketServer.NIO.txt [concat] TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt It is not a showstopper. It is JNI internals test, and failures are apparently caused by timer accuracy. Some test have already been corrected to be more tolerant, but apparently not all of them. For a record, log output: TEST-org.apache.tomcat.jni.TestSocketServer.APR.txt [[[ Testsuite: org.apache.tomcat.jni.TestSocketServer Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1,203 sec Testcase: testBlockingReadFromClientWithTimeout took 1,109 sec FAILED Socket.timeoutSet failed (<1s) [991079171] junit.framework.AssertionFailedError: Socket.timeoutSet failed (<1s) [991079171] at org.apache.tomcat.jni.TestSocketServer.testBlockingReadFromClientWithTimeout(TestSocketServer.java:111) Testcase: testPort took 0 sec Testcase: testNonBlockingAcceptWithNoClient took 0 sec Testcase: testNonBlockingReadThenBlockingReadFromClient took 0,015 sec Testcase: testNonBlockingReadFromClient took 0 sec ]]] TEST-org.apache.tomcat.jni.TestSocketServer.NIO.txt: [[[ Testsuite: org.apache.tomcat.jni.TestSocketServer Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1,328 sec Testcase: testBlockingReadFromClientWithTimeout took 1,204 sec Testcase: testPort took 0 sec Testcase: testNonBlockingAcceptWithNoClient took 0,031 sec FAILED non_blocking accept Socket.APR_SO_NONBLOCK failed ([12755293]>1ms) junit.framework.AssertionFailedError: non_blocking accept Socket.APR_SO_NONBLOCK failed ([12755293]>1ms) at org.apache.tomcat.jni.TestSocketServer.testNonBlockingAcceptWithNoClient(TestSocketServer.java:198) Testcase: testNonBlockingReadThenBlockingReadFromClient took 0,031 sec Testcase: testNonBlockingReadFromClient took 0 sec ]]] TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt: [[[ Testsuite: org.apache.tomcat.jni.TestSocketServer Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1,328 sec Testcase: testBlockingReadFromClientWithTimeout took 1,235 sec Testcase: testPort took 0 sec Testcase: testNonBlockingAcceptWithNoClient took 0,016 sec Testcase: testNonBlockingReadThenBlockingReadFromClient took 0,016 sec FAILED non_blocking client Socket.APR_SO_NONBLOCK false failed junit.framework.AssertionFailedError: non_blocking client Socket.APR_SO_NONBLOCK false failed at org.apache.tomcat.jni.TestSocketServer.testNonBlockingReadThenBlockingReadFromClient(TestSocketServer.java:175) Testcase: testNonBlockingReadFromClient took 0 sec ]]] 3. Checksums: OK 4. Signatures: I think that the ones for the files on dist.apache.org shall be recreated using the stronger key. The ones for files in maven: can be fixed in a future release. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
