On Wed, Jan 24, 2018 at 4:57 PM, Christopher Schultz <ch...@christopherschultz.net> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Coty, > > On 1/24/18 1:34 PM, Coty Sutherland wrote: >> I think this is the right thread to add this :) >> >> Given that we will be able to accept PRs on Github after this >> migration, do we want to add a Travis (or other CI) configuration >> to our repository so that it will do a test build (and maybe test >> one connector) when someone proposes a pull? Doing that will ensure >> we get all of the new code accepted by PRs tested without manual >> intervention or waiting for the ASF build infrastructure to do it. >> You can make passing the tests a condition to accept the PR too I >> believe. > > Could this "feature" be used to DOS some host(s)? If every PR causes a > checkout/compile/test cycle, it could get "expensive".
Possibly, but my thoughts were to use travis (https://travis-ci.org/) which has it's own hosts and such that we won't need to worry about. Travis also allows you to limit concurrent builds and even limit it to only building PRs. Were you worried about the potential for DoSing ASF infra? I just pushed a test .travls.yml in my tomcat fork (https://github.com/csutherl/tomcat/blob/trunk/.travis.yml) so I could play with it a bit. > - -chris > -----BEGIN PGP SIGNATURE----- > Comment: GPGTools - http://gpgtools.org > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQJRBAEBCAA7FiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlppAVQdHGNocmlzQGNo > cmlzdG9waGVyc2NodWx0ei5uZXQACgkQHPApP6U8pFjBPg/+LywMRfUig0DsOkAt > StgtY8dvvBJJyf9H9pQM8cqnjWx/nfKhvGhaaHgCd8ftfynM3k8I9X4iImKlRRhN > xKCRbXyIr7QsCkbUDZqzVoTQeYE3A0OHSgo5kKlauI0+nrFPaoJW0fSAx9Gd4npV > cV4PPsKokYiBbFl8/7q9taZ/FP0wB5QWf3hN1QEUFVyhlKzKhouB+dxmnzZzgBFS > NRBFViOygJvYV299Jcg8UlyFC4HCfLy+L7uFsS5pf7MO29TG71xEMVrdNiMihz+j > TxWG2n6AAK1fu0HS4GTIcan4zQUDtDoQB9VJD1TwOYQATgJQlNQbvaZvMk/+n6Gu > WieMrGyLbJfix7asgv4qkQ80TyCTdQ1M3Ab4afrP0YGVzqIXRKFoyHQgiTZXgs6k > de5Y6uFOgDna13up596BFKL94QkRyirAPXasVbB4QSuynmGiGCpAf7S+KHXb/T5W > Ro2Zs1bHj1vTFB46NqGNJCjXC21ZmvPoujil7evohNc0vEVFNFLqsqcta2A30D6n > +Yp/tbmDzY0xAl1Rp7BEUKVndzIWofvbQ08A41qWLMWTG1n16FjUQJg3xO3YHcDZ > Oy0gWDnYvQlQnFKZs4bRCLle36dkAcZ2GzCwBELbxKKwiXk+mLS+Fz05YGG2BMYt > 7GOhLV/GMhrz2Rs0MEzWgxlKhes= > =ZVjJ > -----END PGP SIGNATURE----- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
