On 24/01/18 18:34, Coty Sutherland wrote: > I think this is the right thread to add this :) > > Given that we will be able to accept PRs on Github after this > migration, do we want to add a Travis (or other CI) configuration to > our repository so that it will do a test build (and maybe test one > connector) when someone proposes a pull? Doing that will ensure we get > all of the new code accepted by PRs tested without manual intervention > or waiting for the ASF build infrastructure to do it. You can make > passing the tests a condition to accept the PR too I believe.
+1 to more CI. I lean towards reporting results rather than hard requirements but I suspect we'll tweak that sort of detail as we go along. Mark > > On Wed, Dec 13, 2017 at 8:52 AM, Rémy Maucherat <r...@apache.org> wrote: >> On Wed, Dec 13, 2017 at 10:23 AM, Mark Thomas <ma...@apache.org> wrote: >> >>> The plan is to switch to "github as master' which is actually a dual >>> master system where commits can be made directly to either github or the >>> ASF. I don't think it matter which we use. My (not recent) experience is >>> that github is faster. >>> >>> Nice setup. >> >> Rémy > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org