On Nov 17, 2017 06:24, "Rainer Jung" <rainer.j...@kippdata.de> wrote:

Am 15.11.2017 um 12:03 schrieb Mark Thomas:

> Version 1.2.16 includes the following changes compared to 1.2.14:
>
> - Update minimum recommended OpenSSL version to 1.0.2m
> - Update minimum recommended APR version to 1.6.3
> - Windows binaries built with OpenSSL 1.0.2m and APR 1.6.3
>
> Various other fixes and improvements. See the changelog for details.
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.16 is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>

+1 to release, thanks for RMing.

3 minor remarks:

- there's a new empty top-level "bin" folder. It also exists as an empty
folder in svn.

- the functional changes are mostly in OCSP and that is probably not really
being used by our TC unit tests


+1, we don't have any documentation around it either. There should be a PR
to remedy the doc issue soon, I'll see if the contributor also wants to
propose a test.


- it seems to me that on Unix/Linux OCSP support is always active if
OpenSSL supports it, but on Windows one needs to enable it. We should
probably sync that behavior before the next release. I currently don't see
a reason, why the platforms should behave differently.


+1. That's what I was getting at with my OCSP thread on the users list.
Also the download page mentions that OCSP support ok Windows is
experimental, if that isn't true it needs an update.



- Tested with APR 1.6.3, OpenSSL 1.0.2m and 1.1.0g,
  and unit tests of TC 8.5 head
- Platforms Solaris 10 Sparc, SLES 11 and 12 64 Bit, RHEL 6 and 7 64 Bits
- configure flag "--enable-maintainer-mode"
- make with gcc 7.2.0 on Solaris and platform gcc on Linux
- Using Java version 1.8.0_144 64 Bit
  - Using "-XX:-UseCompressedClassPointers" on 64 Bit Linux
- SHA1 and MD5 OK
- signatures OK
- gz and zip for sources consistent
- source dist consistent with svn tag
- config.guess and config.sub from apr 1.6.3 (copied by buildconf)
  from this year (OK).
- VERSIONS says OpenSSL 1.0.2m and APR 1.6.3
- recreated release with jnirelease script, results are
  consistent with source dist, except for minor expected diffs in
  generated docs
- make succeeds and builds lib
  - no C warnings
- unit test results for TC
  - no failures

Regards,

Rainer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to