2017-08-24 21:33 GMT+03:00 Mark Thomas <ma...@apache.org>: > On 24/08/17 11:19, Konstantin Kolinko wrote: >> A naive review below. I do not have a working tc-native build to check. >> >> I think your patch is an adaptation of r1805943 (BZ 60290). As such, >> it looks good. >> >> Several thoughts: >> 1) A typo in commit message and in changelog.xml> >> I think it was meant to be s/but setting/by setting/. > > Thanks. Fixed. > > I think Rainer has answered the libtool questions.
Ack. Good answers. Thank you both. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
