Some more answers
Am 24.08.2017 um 12:19 schrieb Konstantin Kolinko:
A naive review below. I do not have a working tc-native build to check.
I think your patch is an adaptation of r1805943 (BZ 60290). As such,
it looks good.
Several thoughts:
1) A typo in commit message and in changelog.xml
I think it was meant to be s/but setting/by setting/.
Fixed by Mark.
2) There exists @TCNATIVE_LIBTOOL_VERSION@ What is its value?
Looking into configure.in, I think it is evaluated rather early,
before $LIBTOOL is set.
That is the tcnative version in libtool syntax, not a libtool version.
For instance for trunk it is 2:13:2 which leads to
libtcnative-1.so.0.2.13. The determination of that version does not use
libtool but instead a script build/get-version.sh which parses the
version info from one of our header files.
3)
APR_SETIFNULL(LIBTOOL, `$apr_config --apr-libtool`)
I wonder whether that --apr-libtool flag should be simply --libtool,
like with --cc and -cpp a few lines above.
Already answered
4)
There exists $APR_LIBTOOL_LIBS.
I wonder what is its value and whether it needs some update as well.
These are libs needed when linking against APR retrieved from the
apr-1-config script of the installed APR. They are not libs needed by
libtool itself and do not depend on the libtool version, neither of the
one included in APR nor on a separate one if we now use the new feature.
Example here on Solaris:
/path/to/lib/libapr-1.la -luuid -lsendfile -lrt -lsocket -lnsl -lpthread
So no need to update.
@Mark: I tested it quickly using the APR provided libtool and then
another build using an older libtool announced via the LIBTOOL env var.
Both build used the expected libtool and were successful.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
