GitHub user isapir opened a pull request:

    https://github.com/apache/tomcat/pull/56

    added methods to translate string names to integer

    This is the basis for tickets
    https://bz.apache.org/bugzilla/show_bug.cgi?id=61127
    https://bz.apache.org/bugzilla/show_bug.cgi?id=61128
    With the added static method `int Channel.getOptionsFromString(String 
input)`
    
    Calling that method with a String input would translate it to the the 
equivalent bitwise-ORd integer of of the options in the comma-separated input, 
so that for example `Channel.getOptionsFromString("async,multicast")` would 
return `72`.
    
    I am not sure yet where the value is read from the configuration file, but 
it would be simple to use the methods added here, e.g. in any Class that 
already has 
    
    ```
        public void setChannelSendOptions(int channelSendOptions) {
            this.channelSendOptions = channelSendOptions;
        }
    ```
    
    We can add
    
    ```
        public void setChannelSendOptions(String channelSendOptions) {
            
this.setChannelSendOptions(Channel.getOptionsFromString(channelSendOptions));
        }
    ```
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/isapir/tomcat trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomcat/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #56
    
----
commit 61c16ed2b5c142c9350d7e2491e2e464bd071f8b
Author: Igal Sapir <d...@21solutions.net>
Date:   2017-05-28T22:07:04Z

    added methods to translate string names to integer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to