https://bz.apache.org/bugzilla/show_bug.cgi?id=60490
Bug ID: 60490
Summary: Several improvements to the ErrorReportValve
Product: Tomcat 8
Version: 8.5.x-trunk
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: 1983-01...@gmx.net
Target Milestone: ----
Created attachment 34531
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34531&action=edit
Patch for ErrorReportValve
Please find attached a patch (against 8.5.x trunk) for the current
ErrorReportValve. It is a slightly modified version of my publically available
EnhancedErrorReportValve.
What has been changed and why:
* Properties:
** Translate 'Type' to French and Spanish
** Apply proper case (upper case) for titles and labels according to Chicago
Manual of Style
** Add stylistically correct en dash in English, semirraya/raya menor in
Spanish and tiret demi-cadratin in French
** Remove all status codes below 400 because they aren't errors and can't be
used with this valve anyway due to line 149/150
(Cross-references aren't present to that bundle)
** Remove reference to org/apache/tomcat/util/http/res/LocalStrings.properties,
this bundle does not exist any more
** Update all descriptions in English by the most recent versions of today's
RFCs (through IANA listings/references)
** Split status codes to reasons and descriptions based on RFCs
* Java:
** Import TomcatCSS class for better readablity of the code
** Obtain reason and description from properties
** Align HTML code to HTML5 style
** Change head/title to status code and reason. The user (of a browser) does
not care about the server running this webapp.
Rather inform the user upfront that an HTTP error has happened and what its
phrase is. More details are on the page itself.
** Have statusHeader contain only general information, details are layed out in
the body
** Don't show in statusHeader message if showReport is false (applies to the
issues above)
** Always include the CSS style because even if showReport is false, it still
remains HTML and a few elements are displayed
** Use boolean getters rather than the fields directly
** Use translated label for 'Type'
** Don't abuse div as hr
** Don't use underline and bold, it is considered as bad style
** Omit the message line if there isn't any
** Don't print server info with rootCauseInLogs as it is confusing with the
version and duplicates the information with the subsequent line
** Use System.lineSeparator() instead of \n
The goal is to clean up old strings, remove duplication and add consistency.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
