Hi fschumacher,
Just a friendly reminder that I had a discussion with kkolinko about this
before.
I seems that it is better to explicitly define the default value rather than
the Boolean.getBoolean syntactic sugar.
private static final boolean onlyAttemptFirstLoader =
-
Boolean.getBoolean(System.getProperty("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader",
"false"));
+
Boolean.getBoolean("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader");
Details can be found here:
https://bz.apache.org/bugzilla/show_bug.cgi?id=58564
------------------------------------------------------------------
From:fschumacher <fschumac...@apache.org>
Time:2015 Nov 22 (Sun) 23:29
To:dev <dev@tomcat.apache.org>
Subject:svn commit: r1715633 - in /tomcat/trunk:
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
webapps/docs/changelog.xml
Author: fschumacher
Date: Sun Nov 22 15:28:55 2015
New Revision: 1715633
URL: http://svn.apache.org/viewvc?rev=1715633&view=rev
Log:
Correct evaluation of system property
<code>org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader</code>.
It was basically ignored before. Reported by coverity scan.
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
tomcat/trunk/webapps/docs/changelog.xml
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java?rev=1715633&r1=1715632&r2=1715633&view=diff
==============================================================================
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ClassLoaderUtil.java
Sun Nov 22 15:28:55 2015
@@ -24,7 +24,7 @@ public class ClassLoaderUtil {
private static final Log log = LogFactory.getLog(ClassLoaderUtil.class);
private static final boolean onlyAttemptFirstLoader =
-
Boolean.getBoolean(System.getProperty("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader",
"false"));
+
Boolean.getBoolean("org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader");
public static Class<?> loadClass(String className, ClassLoader...
classLoaders) throws ClassNotFoundException {
ClassNotFoundException last = null;
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1715633&r1=1715632&r2=1715633&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun Nov 22 15:28:55 2015
@@ -95,6 +95,14 @@
</fix>
</changelog>
</subsection>
+ <subsection name="jdbc-pool">
+ <changelog>
+ <fix>
+ Correct evaluation of system property
<code>org.apache.tomcat.jdbc.pool.onlyAttemptCurrentClassLoader</code>.
+ It was basically ignored before. Reported by coverity scan.
(fschumacher)
+ </fix>
+ </changelog>
+ </subsection>
</section>
<section name="Tomcat 9.0.0.M1" rtext="2015-11-17">
<subsection name="General">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
