On Today at 12:11pm, YS=>Yoav Shapira <[EMAIL PROTECTED]> wrote: YS> [..snip..] YS> YS> If you want to submit a more precise patch, i.e. one that checks for YS> the tag usage and then only circumvents copies if the two files are YS> indeed the same exact path (taking symlinks and catalina_base versus YS> catalina_home into account), good. If you want to submit accompanying YS> test cases, great. Both would be gladly welcomed. YS>
I wouldn't even know where to begin to write a test case for this scenario, so I will decline on that. The patch is easy enough: (http://issues.apache.org/ is down at the moment) Replace: copy(localWar, new File(getAppBase(), basename + ".war")); with: File secondCopy = new File(getAppBase(), basename + ".war"); if( !localWar.getCanonicalPath().equals(secondCopy.getCanonicalPath()) ) { copy(localWar, secondCopy); } All done! YS> Like Filip, I'd -1 the patch as is because it's too general and YS> doesn't seem to take into account scenarios where the two paths are YS> different so the copy does not result in a zero-sized file. YS> YS> Yoav YS> Regards, -- Haroon Rafique <[EMAIL PROTECTED]> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
