Hola,

> False information??? you guys are pretty paranoid. I explained clearly
> that /www/tomcat is a symlink to /www/apache-tomcat-5.5.16.

You can call it paranoia if you wish, but I prefer caution.  I'm not
about to go remove a line code in an important component that we know
is used in several paths through the code (corresponding to several
different deployment scenarios) and that has been stable for a year
plus save for the complaints from one user.  I don't believe that
you're the only user of the tagging feature: simply given the
demographics of Tomcat adoption, I'd be unlikely to believe any one
feature only has one user.  It's far more likely that the bug only
shows up in your particular environment.  No one's contending that
you're seeing bad behavior, we just think the patch is too general and
risky as-is.

If you want to submit a more precise patch, i.e. one that checks for
the tag usage and then only circumvents copies if the two files are
indeed the same exact path (taking symlinks and catalina_base versus
catalina_home into account), good.  If you want to submit accompanying
test cases, great.  Both would be gladly welcomed.

Like Filip, I'd -1 the patch as is because it's too general and
doesn't seem to take into account scenarios where the two paths are
different so the copy does not result in a zero-sized file.

Yoav

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to